[Intel-gfx] [PATCH 06/15] drm/i915: Add a FIXME about drrs/psr interactions
Daniel Vetter
daniel.vetter at ffwll.ch
Mon Jun 16 19:51:26 CEST 2014
Can't review this right now due to lack of DRRS code.
Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
Cc: Vandana Kannan <vandana.kannan at intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
---
drivers/gpu/drm/i915/intel_dp.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index c7d625040e3d..ac1cef459a7b 100644
--- a/drivers/gpu/drm/i915/intel_dp.c
+++ b/drivers/gpu/drm/i915/intel_dp.c
@@ -4121,6 +4121,11 @@ void intel_dp_set_drrs_state(struct drm_device *dev, int refresh_rate)
return;
}
+ /*
+ * FIXME: This needs proper synchronization with psr state. But really
+ * hard to tell without seeing the user of this function of this code.
+ * Check locking and ordering once that lands.
+ */
if (INTEL_INFO(dev)->gen < 8 && intel_edp_is_psr_enabled(dev)) {
DRM_DEBUG_KMS("DRRS is disabled as PSR is enabled\n");
return;
--
2.0.0
More information about the Intel-gfx
mailing list