[Intel-gfx] [PATCH] drm/i915/bdw: Broaden FBC resolution limit to 4096x4096

[Daniel Vetter]

On Mon, Jun 16, 2014 at 06:11:45PM +0100, Damien Lespiau wrote:
> On Mon, Jun 16, 2014 at 05:52:12PM +0100, Damien Lespiau wrote:
> > From: Daisy Sun <daisy.sun at intel.com>
> > 
> > Staring from BDW, the resolution limit of FBC has increased to
> > 4096x4096>
> > 
> > Issue: APDEV-2935
> > Otc-Tracker: VIZ-3826
> > Change-Id: I842f64e3cf2c0d18d29ef1bcfef3b9bb1f1764ac
> > Signed-off-by: Daisy Sun <daisy.sun at intel.com>
> 
> Reviewed-by: Damien Lespiau <damien.lespiau at intel.com>

Iirc 4kx4k is allowed on hsw already, albeit with the lower 2k lines being
uncompressed. Please double-check bspec and update the patch.

Also: Please insert rant here that I've written a mail a year ago about
the piles of little issues in our fbc feature checking.
-Daniel

> 
> -- 
> Damien
> 
> > ---
> >  drivers/gpu/drm/i915/intel_pm.c | 5 ++++-
> >  1 file changed, 4 insertions(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index 0b088fe..8cc60fc 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -529,7 +529,10 @@ void intel_update_fbc(struct drm_device *dev)
> >  		goto out_disable;
> >  	}
> >  
> > -	if (IS_G4X(dev) || INTEL_INFO(dev)->gen >= 5) {
> > +	if (INTEL_INFO(dev)->gen >= 8) {
> > +		max_width = 4096;
> > +		max_height = 4096;
> > +	} else if (IS_G4X(dev) || INTEL_INFO(dev)->gen >= 5) {
> >  		max_width = 4096;
> >  		max_height = 2048;
> >  	} else {
> > -- 
> > 1.8.3.1
> > 
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx at lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch