[Intel-gfx] [PATCH 08/15] drm/i915: Don't try to disable psr harder from the work item

Rodrigo Vivi rodrigo.vivi at gmail.com
Tue Jun 17 02:20:48 CEST 2014


Now I'm wondering about the psr_updated you removed and without this
disabling at this point if you alternate to fbcon you might miss most of
screen updates if not all...


On Mon, Jun 16, 2014 at 10:51 AM, Daniel Vetter <daniel.vetter at ffwll.ch>
wrote:

> It's disabled already except when we've raced.
>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
> ---
>  drivers/gpu/drm/i915/intel_dp.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c
> b/drivers/gpu/drm/i915/intel_dp.c
> index 10bcc052df4b..3e0861be9c5d 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -1876,9 +1876,7 @@ static void intel_edp_psr_work(struct work_struct
> *work)
>                 container_of(work, typeof(*dev_priv), psr.work.work);
>         struct intel_dp *intel_dp = dev_priv->psr.enabled;
>
> -       if (!intel_edp_psr_match_conditions(intel_dp))
> -               intel_edp_psr_disable(intel_dp);
> -       else
> +       if (intel_edp_psr_match_conditions(intel_dp))
>                 intel_edp_psr_do_enable(intel_dp);
>  }
>
> --
> 2.0.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>



-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/intel-gfx/attachments/20140616/d155eb0d/attachment.html>


More information about the Intel-gfx mailing list