[Intel-gfx] [PATCH] Fixed the review issues for pm_rc6_residency IGT case

[Daniel Vetter]

On Tue, Jun 17, 2014 at 12:03 AM, Jesse Barnes <jbarnes at virtuousgeek.org> wrote:
> So, what is revert-worthy in i-g-t?  Open review items?  Requests for
> change?  False test failures?  False test passes?  Crashing tests?  I'd
> vote for the latter 3 myself; did this fall into any of those
> categories?

Imo this isn't about when to revert, but about the responsibilities of
the committer. Especially for new contributors that imo includes full
review and making sure the test has a bit polish applied and uses all
the latest igt infrastructure. My impression was that Ben didn't do
that so I asked him whether he'll follow up. From irc I've gotten the
impression that he won't do that work (maybe that was a
misunderstanding) and that I should go ahead.

That I reverted the patch is just personal choice - for polishing
patches I much prefer one clean patch that gets revised than
committing early and then applying a few fixup patches. It's simply
the process I'm used to from the kernel side.

I don't mind at all if other people do this differently, as long as it
gets done. Which in this case here didn't look like. And if you've
read my first mail in this thread there's still work left to do here.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch