[Intel-gfx] [PATCH 00/10] Support for 180 degree HW rotation

[Daniel Vetter]

On Wed, Jun 18, 2014 at 05:27:41PM +0530, Jindal, Sonika wrote:
> 
> 
> On 6/18/2014 5:22 PM, Daniel Vetter wrote:
> >On Wed, Jun 18, 2014 at 05:14:49PM +0530, sonika.jindal at intel.com wrote:
> >>From: Sonika Jindal <sonika.jindal at intel.com>
> >>
> >>Enables 180 degree rotation for sprite and primary planes.
> >>Updated the primary plane rotation support as per the new universal plane
> >>design.
> >>
> >>Most of these patches were already reviewed in intel-gfx in February 2014 thats
> >>why there is version history in few of them.
> >>
> >>Testcase: kms_rotation_crc
> >>This igt can be extended for clipped rotation cases. Right it only tests 180
> >>degree rotation for sprite and primary plane with crc check.
> >>
> >>Sonika Jindal (1):
> >>   drm/i915: Add 180 degree primary plane rotation support
> >>
> >>Ville Syrjälä (9):
> >>   drm: Move DRM_ROTATE bits out of omapdrm into drm_crtc.h
> >>   drm: Add support_bits parameter to drm_property_create_bitmask()
> >>   drm: Add drm_mode_create_rotation_property()
> >>   drm/omap: Switch omapdrm over to drm_mode_create_rotation_property()
> >>   drm: Add drm_rect rotation functions
> >>   drm: Add drm_rotation_simplify()
> >>   drm/i915: Add 180 degree sprite rotation support
> >>   drm/i915: Make intel_plane_restore() return an error
> >>   drm/i915: Add rotation property for sprites
> >
> >Pleas don't repost entire patch series on the same day without a changelog
> >in the cover letter explaining what's going on and what changed.
> >
> >If you just need to repost a few patches that changed due to review,
> >please do that with an in-reply-to directly to the relevant discussion.
> >
> >If everyone reposts their big patch series a few times a day we'll have
> >utter chaos.
> >-Daniel
> 
> I am sorry for this. I thought creating a new patchset should be good,
> missed updating it in cover letter.
> I will keep this in mind.

It's always a balancing act - if the threads nest too deeply eventually
in-reply-to becomes a mess, too. But a rule of thumb is that you should
only resend when the patch series changed completely or once review has
settled down (so only after a few days) and the review thread has become
too deeply nested.

But resending the entire series on the same day before review has
concluded is definitely too early. Our team is global so without a full
day not everyone even had a chance to look at it - us west coast is still
fast asleep ;-)
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch