[Intel-gfx] [PATCH 53/53] !UPSTREAM: drm/i915: Use MMIO flips

[Mateo Lozano, Oscar]

> -----Original Message-----
> From: Daniel Vetter [mailto:daniel.vetter at ffwll.ch] On Behalf Of Daniel
> Vetter
> Sent: Wednesday, June 18, 2014 10:01 PM
> To: Mateo Lozano, Oscar
> Cc: intel-gfx at lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH 53/53] !UPSTREAM: drm/i915: Use MMIO
> flips
> 
> On Fri, Jun 13, 2014 at 04:38:11PM +0100, oscar.mateo at intel.com wrote:
> > From: Sourab Gupta <sourab.gupta at intel.com>
> >
> > If we want flips to work, either we create an Execlists-aware version
> > of intel_gen7_queue_flip, or we don't place commands directly in the
> > ringbuffer.
> >
> > When upstreamed, this patch should implement the second option:
> 
> Usually we just mention such requirements in the cover letter of the series
> and don't include them.
> -Daniel

Well, since we have it here, there is something I wanted to ask about this:

MODULE_PARM_DESC(use_mmio_flip, "use MMIO flips (-1=never, 0=driver discretion [default], 1=always)"); 

The "driver discretion" option will blow up with Execlists :(
How do I tackle this? an execlists version of intel_gen7_queue_flip? sanitizing use_mmio_flip when execlists get enabled? I really don´t have a preference...