[Intel-gfx] [PATCH] drm/i915: Don't just say it, actually force edp vdd

Chris Wilson chris at chris-wilson.co.uk
Tue Mar 4 09:17:36 CET 2014


On Tue, Mar 04, 2014 at 12:42:44AM +0100, Patrik Jakobsson wrote:
> This patch fixes the blank screen bug introduced in 3.14-rc1 on the
> MacBook Air 6,2. The comments state that we need to force edp vdd so
> lets put it back.
> 
> The regression was introduced by the following commit:
> 
> commit dff392dbd258381a6c3164f38420593f2d291e3b
> Author: Paulo Zanoni <paulo.r.zanoni at intel.com>
> Date:   Fri Dec 6 17:32:41 2013 -0200
> 
>     drm/i915: don't touch the VDD when disabling the panel
> 
> v2: Wrap intel_disable_dp() with _vdd_on and _vdd_off
> 
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=74628
> Cc: Paulo Zanoni <paulo.r.zanoni at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Signed-off-by: Patrik Jakobsson <patrik.r.jakobsson at gmail.com>

This brings the code into line with the comments, and has the bonus of
working on a fiddly panel, so

Acked-by: Chris Wilson <chris at chris-wilson.co.uk>

I don't feel confident enough with the DP sequencing to say why it has
to be so though.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list