[Intel-gfx] [PATCH 3/6] drm/i915: Add support for DRRS to switch RR

[Chris Wilson]

On Wed, Mar 05, 2014 at 03:13:06PM +0530, Vandana Kannan wrote:
> +void intel_dp_set_drrs_state(struct drm_device *dev, int refresh_rate)
> +{
> +	struct drm_i915_private *dev_priv = dev->dev_private;
> +	struct intel_encoder *encoder;
> +	struct intel_dp *intel_dp = NULL;
> +	struct intel_crtc_config *config = NULL;
> +	struct intel_crtc *intel_crtc = NULL;
> +	struct intel_connector *intel_connector = dev_priv->drrs.connector;
> +	u32 reg, val;
> +	int index = 0;

This routine touches a register and reads state guarded by modeset locks,
I don't see any documentation to make sure the caller complies with
holding the right locks.

And since this function isn't used yet, I can't check that the callers
are correct at this point in time either. Please, please do document
locking requirements on new functions.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre