[Intel-gfx] [PATCH] drm/i915: reverse dp link param selection, prefer fast over wide again

Daniel Vetter daniel at ffwll.ch
Wed Mar 5 19:14:47 CET 2014


On Mon, Mar 03, 2014 at 04:36:11PM +0200, Jani Nikula wrote:
> On Mon, 03 Mar 2014, Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> > ... it's this time of the year again. Originally we've frobbed this to
> > fix up some regressions, but maybe our DP code improved sufficiently
> > now that we can dare to do again what the spec recommends.
> >
> > This reverts
> >
> > commit 2514bc510d0c3aadcc5204056bb440fa36845147
> > Author: Jesse Barnes <jbarnes at virtuousgeek.org>
> > Date:   Thu Jun 21 15:13:50 2012 -0700
> >
> >     drm/i915: prefer wide & slow to fast & narrow in DP configs
> >
> > I'm pretty sure I'll regret this patch, but otoh I expect we won't
> > make progress here without poking the devil occasionally.
> 
> Reviewed-by: Jani Nikula <jani.nikula at intel.com>
> 
> I agree we should bite the bullet and do this. This is what the DP specs
> tell us to do. I'm pretty sure there will be regressions, but I'm also
> starting to believe there's a greater number of machines that are
> currently either broken beyond repair or papered over with some hacks
> than the number that will regress. We should just dig into them and fix
> them instead of burying our heads in the sand.

Queued for -next, thanks for the review.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list