[Intel-gfx] [PATCH] drm/i915/bdw: Fix 4g GGTT insert entries regression

[Jani Nikula]

On Wed, 05 Mar 2014, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Wed, Mar 05, 2014 at 12:19:51PM -0800, Ben Widawsky wrote:
>> On Wed, Mar 05, 2014 at 07:24:37AM -0800, Ben Widawsky wrote:
>> > On Wed, Mar 05, 2014 at 11:13:12AM +0200, Jani Nikula wrote:
>> > > On Wed, 05 Mar 2014, Ben Widawsky <benjamin.widawsky at intel.com> wrote:
>> > > > The PDE needs to wrap after writing all the PTEs. Quite a small/silly
>> > > > bug to find in the massive change. It was introduced:
>> > > > commit 307dc4f99f6d3a74a78b0e776838f35b2004f14d
>> > > > Author: Ben Widawsky <benjamin.widawsky at intel.com>
>> > > > Date:   Thu Feb 20 11:51:21 2014 -0800
>> > > >
>> > > >     drm/i915/bdw: Reorganize PT allocations
>> > > 
>> > > As noted in the bug, the commit merged to dinq is correct, and the
>> > > commit referenced above apparently only lives in some temporary branch.
>> > > 
>> > > BR,
>> > > Jani.
>> > > 
>> > 
>> > My eyes are playing tricks on me. Sorry for the noise.
>> > 
>> 
>> It's not my eyes. It's something else. WTF is going on?
>
> My apologies, I seem to have been blind. Patch merged, will squash in.

I didn't just trust Daniel, I actually looked at the code before sending
the mail. And, well, *facepalm*. Apparently I mistook the ++pte that's
there for the new one added here. Sorry Ben.

BR,
Jani.


> -Daniel
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch

-- 
Jani Nikula, Intel Open Source Technology Center