[Intel-gfx] [PATCH v2 18/21] drm/i915: vlv: factor out valleyview_display_irq_install

[Jesse Barnes]

On Tue,  4 Mar 2014 19:23:07 +0200
Imre Deak <imre.deak at intel.com> wrote:

> +void valleyview_enable_display_irqs(struct drm_i915_private *dev_priv)
> +{
> +	assert_spin_locked(&dev_priv->irq_lock);
> +
> +	if (dev_priv->display_irqs_enabled)
> +		return;
> +
> +	dev_priv->display_irqs_enabled = true;
> +
> +	if (dev_priv->dev->irq_enabled)
> +		valleyview_display_irqs_install(dev_priv);
> +}

This made me do a double take, then I saw you were checking the actual
drm_device irq enabled state rather than checking the new field again...

Looks good.

Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center