[Intel-gfx] [PATCH 6/8] drm/i915: don't bother enabling swizzle bits on gen7+

Jesse Barnes jbarnes at virtuousgeek.org
Sun Mar 9 18:33:42 CET 2014


On Sat, 8 Mar 2014 11:36:24 +0100
Daniel Vetter <daniel at ffwll.ch> wrote:

> On Fri, Mar 07, 2014 at 08:57:53AM -0800, Jesse Barnes wrote:
> > As of IVB, the memory controller does internal swizzling already, so we
> > shouldn't need to enable these.  Based on an earlier fix from Kristian.
> > 
> > Reported-by: Kristian Høgsberg <hoegsberg at gmail.com>
> > Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>
> 
> Imo the right approach here is to check whether any of the
> preserved/inherited framebuffers has tiling enabled, and if so we need to
> preserve the swizzling mode the bios has set.
> 
> Also this should be done on gen6+ since those are the machines where
> swizzling can be changed.

Ah yeah good point... haven't checked to see if any BIOSes enable this
automatically.

-- 
Jesse Barnes, Intel Open Source Technology Center



More information about the Intel-gfx mailing list