[Intel-gfx] [PATCH 1/4] drm/i915: Reduce the time we hold struct mutex in intel_pipe_set_base()

[Chris Wilson]

On Tue, Mar 11, 2014 at 07:37:33PM +0200, ville.syrjala at linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> We don't need to hold struct_mutex all through intel_pipe_set_base(),
> just need to hold it while pinning/unpinning the buffers.
> 
> So reduce the struct_mutext usage in intel_pipe_set_base() just like we
> did for the sprite code in:
>  commit 82284b6becdbef6d8cd3fb43e8698510833a5129
>  Author: Ville Syrjälä <ville.syrjala at linux.intel.com>
>  Date:   Tue Oct 1 18:02:12 2013 +0300
> 
>     drm/i915: Reduce the time we hold struct mutex in sprite update_plane code
> 
> The FBC and PSR locking is still entirely fubar. That stuff was
> previouly done while holding struct_mutex, so leave it there for now.

Yup. I am amazed we enabled FBC when it has known deadlocks...

Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre