[Intel-gfx] [PATCH 1/3] tests/pm_rps: ducttape for igt fork helper cleanup issues

Daniel Vetter daniel.vetter at ffwll.ch
Fri Mar 14 16:34:29 CET 2014


On Fri, Mar 14, 2014 at 3:29 PM, Jeff McGee <jeff.mcgee at intel.com> wrote:
> Unfortunately there are probably several ways in which a failed subtest will
> contaminate subsequent subtests if all are run in the same process instance.
> I asked about that earlier and you said that we don't concern too much about
> it because the preferred way to run is with a test runner and each subtest
> executed in a separate instance. If we do in fact care about supporting all
> subtests in a single instance, can we put in place a subtest exit handler?
> That would solve all issues similar to this.

Yeah, that's my long-term idea, hence the FIXME comment. But
historically I've fumbled way too many special-cases wrt forked
children, subtests and getting the exit handler logic right. So I want
to do this carefully and have it all covered in a pile of igt
testcases to make sure it actually does what I want it to do.

Since I'm terribly busy writing igt library api docs atm I've
postponed this. The quick hack in this patch here just fixed the
annoying assert while I've hacked around on the pm_rps testcase.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list