[Intel-gfx] [PATCH] drm/i915: Use the correct format string modifier for ptrdiff_t

Volkin, Bradley D bradley.d.volkin at intel.com
Tue Mar 18 18:53:01 CET 2014


Thanks for fixing this Damien.

Reviewed-by: Brad Volkin <bradley.d.volkin at intel.com>

On Tue, Mar 18, 2014 at 05:43:08PM +0000, Damien Lespiau wrote:
> When compiling on 32bits, I have the following warning:
> 
> drivers/gpu/drm/i915/i915_cmd_parser.c:405:4: warning: format ‘%ld’
> expects argument of type ‘long int’, but argument 7 has type ‘int’
> [-Wformat=]
>     DRM_DEBUG_DRIVER("CMD: Command length exceeds batch length: 0x%08X
>     length=%d batchlen=%ld\n",
> 
> The ptrdiff_t type has its own modifier: 't'.
> 
> Cc: Brad Volkin <bradley.d.volkin at intel.com>
> Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>
> ---
>  drivers/gpu/drm/i915/i915_cmd_parser.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/i915_cmd_parser.c b/drivers/gpu/drm/i915/i915_cmd_parser.c
> index 7a5756e..0eaed44 100644
> --- a/drivers/gpu/drm/i915/i915_cmd_parser.c
> +++ b/drivers/gpu/drm/i915/i915_cmd_parser.c
> @@ -402,7 +402,7 @@ int i915_parse_cmds(struct intel_ring_buffer *ring,
>  			length = ((*cmd & desc->length.mask) + LENGTH_BIAS);
>  
>  		if ((batch_end - cmd) < length) {
> -			DRM_DEBUG_DRIVER("CMD: Command length exceeds batch length: 0x%08X length=%d batchlen=%ld\n",
> +			DRM_DEBUG_DRIVER("CMD: Command length exceeds batch length: 0x%08X length=%d batchlen=%td\n",
>  					 *cmd,
>  					 length,
>  					 batch_end - cmd);
> -- 
> 1.8.3.1
> 



More information about the Intel-gfx mailing list