[Intel-gfx] [PATCH] drm/i915: Fix unsafe loop iteration over vma whilst unbinding them

Jani Nikula jani.nikula at linux.intel.com
Fri Mar 21 12:09:48 CET 2014


On Fri, 21 Mar 2014, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Fri, Mar 21, 2014 at 07:51:58AM +0000, Chris Wilson wrote:
>> On Fri, Mar 21, 2014 at 07:40:56AM +0000, Chris Wilson wrote:
>> > On non-LLC platforms, when changing the cache level of an object, we may
>> > need to unbind it show that prefetching across page boundaries does not
>> s/show/so/
>> > cross into a different memory domain. This requires us to unbind
>> > conflicting vma, but we did so was iterating over the objects vma in an
>> s/was//
>> > unsafe manner (as the list was being modified as we iterated).
>> 
>> Coffee will kick in in about 5 minutes.
>
> Fixed and applied, thanks for the patch.

Given the regression was introduced in v3.12 I thought this would've
been fixes & cc: stable.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Technology Center



More information about the Intel-gfx mailing list