[Intel-gfx] [PATCH 01/26] drm/i915: Split out verbose PPGTT dumping

[Chris Wilson]

On Sat, Mar 22, 2014 at 11:13:17AM -0700, Ben Widawsky wrote:
> On Thu, Mar 20, 2014 at 12:08:00PM +0000, Chris Wilson wrote:
> > On Thu, Mar 20, 2014 at 11:57:42AM +0000, Chris Wilson wrote:
> > >  static void gen6_ppgtt_info(struct seq_file *m, struct drm_device *dev, bool verbose)
> > > @@ -1838,14 +1841,11 @@ static void gen6_ppgtt_info(struct seq_file *m, struct drm_device *dev, bool ver
> > >  
> > >  	list_for_each_entry_reverse(file, &dev->filelist, lhead) {
> > >  		struct drm_i915_file_private *file_priv = file->driver_priv;
> > > -		struct i915_hw_ppgtt *pvt_ppgtt;
> > >  
> > > -		pvt_ppgtt = ctx_to_ppgtt(file_priv->private_default_ctx);
> > >  		seq_printf(m, "proc: %s\n",
> > >  			   get_pid_task(file->pid, PIDTYPE_PID)->comm);
> > 
> > And 
> > 	seq_printf(m, "\nproc: %s\n",
> > for good measure
> > 
> > > -		print_ppgtt(m, pvt_ppgtt, "Default context");
> > > -		if (verbose)
> > > -			idr_for_each(&file_priv->context_idr, per_file_ctx, m);
> > > +		idr_for_each(&file_priv->context_idr, per_file_ctx,
> > > +			     (void *)((unsigned long)m | verbose));
> > >  	}
> > >  }
> > >  
> > > 
> > > -- 
> 
> Thanks, I like it. I'm assuming you didn't want the count_pt_pages stuck
> in at this point (your diff was based on the end result)? I can do that
> if you prefer it. It seems pointless to me though.

Maybe pointless to you, but it helped me to know when they were fully
populated - without having to look back at the constants.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre