[Intel-gfx] [PATCH 25/28] lib: s/igt_env_set/igt_check_boolean_env_var

Daniel Vetter daniel.vetter at ffwll.ch
Sun Mar 23 15:18:59 CET 2014


So I wasn't really happy with env_set since it's way too close to
setenv(), whic actually _sets_ and environment variable. So use check
instead of set as the verb (well adjective for env_set).

Also sprinkle in some hints that we talk about a boolean setting here.

Signed-off-by: Daniel Vetter <daniel.vetter at ffwll.ch>
---
 lib/igt_aux.c  | 6 +++---
 lib/igt_aux.h  | 2 +-
 lib/igt_core.c | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/lib/igt_aux.c b/lib/igt_aux.c
index 177f52da53f7..00a719c2563f 100644
--- a/lib/igt_aux.c
+++ b/lib/igt_aux.c
@@ -134,7 +134,7 @@ void igt_stop_signal_helper(void)
 }
 
 /**
- * igt_env_set:
+ * igt_check_boolean_env_var:
  * @env_var: environment variable name
  * @default_value: default value for the environment variable
  *
@@ -144,7 +144,7 @@ void igt_stop_signal_helper(void)
  * The boolean value of the environment variable @env_var as decoded by atoi()
  * if it is set and @default_value if the variable is not set.
  */
-bool igt_env_set(const char *env_var, bool default_value)
+bool igt_check_boolean_env_var(const char *env_var, bool default_value)
 {
 	char *val;
 
@@ -167,7 +167,7 @@ bool igt_aub_dump_enabled(void)
 	static int dump_aub = -1;
 
 	if (dump_aub == -1)
-		dump_aub = igt_env_set("IGT_DUMP_AUB", false);
+		dump_aub = igt_check_boolean_env_var("IGT_DUMP_AUB", false);
 
 	return dump_aub;
 }
diff --git a/lib/igt_aux.h b/lib/igt_aux.h
index eb6371280c1b..25a479f28970 100644
--- a/lib/igt_aux.h
+++ b/lib/igt_aux.h
@@ -40,7 +40,7 @@ void igt_permute_array(void *array, unsigned size,
 						 unsigned i,
 						 unsigned j));
 void igt_progress(const char *header, uint64_t i, uint64_t total);
-bool igt_env_set(const char *env_var, bool default_value);
+bool igt_check_boolean_env_var(const char *env_var, bool default_value);
 
 bool igt_aub_dump_enabled(void);
 
diff --git a/lib/igt_core.c b/lib/igt_core.c
index ed631f167b44..2fe74f5a23d6 100644
--- a/lib/igt_core.c
+++ b/lib/igt_core.c
@@ -1111,7 +1111,7 @@ bool igt_run_in_simulation(void)
 	static int simulation = -1;
 
 	if (simulation == -1)
-		simulation = igt_env_set("INTEL_SIMULATION", false);
+		simulation = igt_check_boolean_env_var("INTEL_SIMULATION", false);
 
 	return simulation;
 }
-- 
1.8.5.2




More information about the Intel-gfx mailing list