[Intel-gfx] [PATCH] drm/i915: Upgrade execbuffer fail after resume failure to EIO

Daniel Vetter daniel at ffwll.ch
Tue Mar 25 09:07:00 CET 2014


On Tue, Mar 25, 2014 at 9:03 AM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> If we try to execute on a known ring, but it has failed to be
> initialised correctly, report that the GPU is hung rather than the
> command invalid. This leaves us reporting EINVAL only if the user
> requests execution on a ring that is not supported by the device.
>
> This should prevent UXA from getting stuck in a null render loop after a
> failed resume.
>
> Reported-by: Jiri Kosina <jikos at jikos.cz>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=76554
> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>

Feels a bit like duct-tape ... Shouldn't we instead stop tearing down
ringbuffer structures over suspend/resume? And maybe the same for init
with your patch applied.

Or we simply check for wedged first thing in execbuf ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list