[Intel-gfx] [PATCH] drm/i915: Enable FBC on GEN7 by default

[Daniel Vetter]

On Tue, Mar 25, 2014 at 8:27 AM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> On Mon, Mar 24, 2014 at 06:21:22PM -0700, Ben Widawsky wrote:
>> I am not clear why we've never enabled it by default for GEN7. Looking
>> at the git hostiry, it seems Rodrigo disabled it by default, and it's
>> never been turned on. Quite a few fixes have gone in over the past year,
>> and I think many of us are running this successfully.
>>
>> If there is some reason we know of why we don't enable this by default
>> on GEN7, then please ignore the patch, and forgive my laziness.
>
> Other than the major performance degredation due to our implementation,
> and that there is a known deadlock (when unplugging/plugging in external
> displays) due to the broken locking... It should not have been enabled.

Also, have you run the full kms_fbc_crc testsuite to make sure it's
actually functionally correct? Iirc we even fail at that stage still
on some platforms ...
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch