[Intel-gfx] [RFC] drm/i915: Simplify page allocation loop a bit

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Wed Mar 26 18:33:04 CET 2014


On 03/26/2014 05:11 PM, Chris Wilson wrote:
> On Wed, Mar 26, 2014 at 04:48:47PM +0000, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>>
>> Looks like there are some redundant lines in the main loop of
>> i915_gem_object_get_pages_gtt.
>>
>> I haven't tested this so just RFC please.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
>> Cc: Imre Deak <imre.deak at intel.com>
>
> I am pretty sure we can't drop CONFIG_SWIOTLB as swiotlb_nr_tbl only
> exists when lib/swiotlb.c is built i.e. #if IS_ENABLED(CONFIG_SWIOTLB).

I think you're right. I'll repost. Although it diminishes the 
attractiveness of the whole line reducing enterprise a bit.

Thanks,

Tvrtko



More information about the Intel-gfx mailing list