[Intel-gfx] [PATCH] drm: Specify a bit more the DRM_CAP_CURSOR_{WIDTH, HEIGHT} caps

Chris Wilson chris at chris-wilson.co.uk
Fri Mar 28 13:46:19 CET 2014


On Fri, Mar 28, 2014 at 12:31:05PM +0000, Damien Lespiau wrote:
> Earlier this week, there was a bit of confusion about those new
> capabilities, to the point I think it's better to document the intention
> and API contract.
> 
> The comment documents the current situation:
>  - the radeon driver returns the only valid size for the hw
>  - i915 returns the maximun cursor size
>  - other drivers fall back to returning 64x64
> 
> The common contract is to return a valid cursor size.
> 
> Cc: Sagar Kamble <sagar.a.kamble at intel.com>
> Cc: Chris Wilson <chris at chris-wilson.co.uk>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Cc: Imre Deak <imre.deak at intel.com>
> Signed-off-by: Damien Lespiau <damien.lespiau at intel.com>

Agreed. Imho, it suits us to return the maximum possible size for
-modesetting as it enables a broader range of userspace to use hw
cursors with the only overhead of enlarged WMs.
Reviewed-by: Chris Wilson <chris at chris-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list