[Intel-gfx] [PATCH] drm/i915: remove user GTT mappings early during runtime suspend

Chris Wilson chris at chris-wilson.co.uk
Tue May 6 13:40:11 CEST 2014


On Tue, May 06, 2014 at 02:28:50PM +0300, Imre Deak wrote:
> Currently user space can access GEM buffers mapped to GTT through
> existing mappings concurrently while the platform specific suspend
> handlers are running.  Since these handlers may change the HW state in a
> way that would break such accesses, remove the mappings before calling
> the handlers.

Hmm, but you never locked the device, so what is preventing those
concurrent accesses from refaulting in GTT entires anyway. Please explain
the context under which the runtime suspend code executes, and leave
that explanation within easy reach of intel_runtime_suspend() -
preferrably with testing of those assumptions.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list