[Intel-gfx] [IGT PATCH] intel_bios_reader: make edp block decode match kernel

[Damien Lespiau]

On Tue, May 06, 2014 at 07:04:21PM +0300, Jani Nikula wrote:
> On Tue, 06 May 2014, Damien Lespiau <damien.lespiau at intel.com> wrote:
> > On Tue, May 06, 2014 at 02:27:23PM +0300, Jani Nikula wrote:
> >> All the somewhat recent VBT specs and the kernel have different format
> >> for the eDP block than what the tool decodes. What the tool does *may*
> >> be correct for really old VBT, but I have no specs or other reference to
> >> suppor this. Just do what the kernel does, that's what we're interested
> >> in anyway.
> >> 
> >> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> >
> > Reviewed-by: Damien Lespiau <damien.lespiau at intel.com>
> >
> > You may want to add checks on the VBT revision that introduce the
> > different parameters.
> 
> I *wanted* to. But the versions in the spec apparently get changed also
> when that part about the spec actually hasn't changed. At least my
> 140-something spec had some of the same stuff that was indicated as
> having been added at 150-something. :(
> 
> > We're also missing the VswingPreEmphasisValue fields from rev. 173.
> 
> Yup, need to be added later (when we actually start using those).
> 
> Ok to push?

Sure!

-- 
Damien