[Intel-gfx] [PATCH 3/4] drm/i915: Kill vblank waits after pipe enable on gmch platforms

Ville Syrjälä ville.syrjala at linux.intel.com
Fri May 9 11:09:46 CEST 2014


On Fri, May 09, 2014 at 07:03:09AM +0100, Chris Wilson wrote:
> On Thu, May 08, 2014 at 07:23:15PM +0300, ville.syrjala at linux.intel.com wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > The pipe might not start to actually run until the port has been enabled
> > (depends on the platform and port type). So don't try to wait for vblank
> > after we enabled the pipe but haven't yet enabled the port.
> 
> I am pretty sure those waits were in the docs. Pretty sure, not certain
> though.

I didn't find them anywhere. The only vblank waits I see are the ones
for gen2 between disabling the planes and the pipe since the pipe
disable isn't double buffered on vblank. And that wait is still there
due to intel_disable_primary_hw_plane(). If my mmio vs. CS flip race
series ever gets reviewed that also gets killed, but I do add back an
explicit vblank wait for gen2 only into i9xx_crtc_disable().

-- 
Ville Syrjälä
Intel OTC



More information about the Intel-gfx mailing list