[Intel-gfx] [PATCH] drm/i915: Use the connector name in fbdev debug messages

Damien Lespiau damien.lespiau at intel.com
Tue May 13 15:02:58 CEST 2014


On Tue, May 13, 2014 at 01:59:16PM +0100, Chris Wilson wrote:
> On Tue, May 13, 2014 at 01:51:46PM +0100, Damien Lespiau wrote:
> > On Tue, May 13, 2014 at 01:45:09PM +0100, Chris Wilson wrote:
> > > -		DRM_DEBUG_KMS("connector %s on crtc %d: %s\n",
> > > +		DRM_DEBUG_KMS("connector %s on pipe %d [CRTC:%d]: %dx%d%s\n",
> > >  			      drm_get_connector_name(connector),
> > > +			      pipe_name(to_intel_crtc(encoder->crtc)->pipe),
> > 
> > pipe_name() gives you a char.
> 
> Using name was an afterthought. But other than, sane?

Yes! With that fixed, definitely a

Reviewed-by: Damien Lespiau <damien.lespiau at intel.com>

-- 
Damien



More information about the Intel-gfx mailing list