[Intel-gfx] [PATCH 04/50] drm/i915: Extract trivial parts of ring init (early init)

Chris Wilson chris at chris-wilson.co.uk
Tue May 13 15:47:37 CEST 2014


On Tue, May 13, 2014 at 03:26:51PM +0200, Daniel Vetter wrote:
> On Fri, May 09, 2014 at 01:08:34PM +0100, oscar.mateo at intel.com wrote:
> > diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c b/drivers/gpu/drm/i915/i915_gpu_error.c
> > index 2d81985..8f37238 100644
> > --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> > +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> > @@ -886,7 +886,7 @@ static void i915_gem_record_rings(struct drm_device *dev,
> >  	for (i = 0; i < I915_NUM_RINGS; i++) {
> >  		struct intel_ring_buffer *ring = &dev_priv->ring[i];
> >  
> > -		if (ring->dev == NULL)
> > +		if (!intel_ring_initialized(ring))
> >  			continue;

Besides this was deliberately written not to use
intel_ring_initialized().
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list