[Intel-gfx] [PATCH v5] drm/i915: Replaced Blitter ring based flips with MMIO flips for VLV

Daniel Vetter daniel at ffwll.ch
Mon May 19 15:41:08 CEST 2014


On Mon, May 19, 2014 at 3:06 PM, Ville Syrjälä
<ville.syrjala at linux.intel.com> wrote:
>> So why can't we just latch a work item which uses all the established
>> seqno waiting stuff and so avoids all these issues
>
> I hate blocking and waiting for stuff. It usually means all kinds of lock
> dropping tricks, and extra hurdles if you want to cancel the operation.
> My brain just can't deal with it. I much prefer a nice and simple event
> based mechanism.

Hm, I'm the other way round - I prefer stack based state machines over
continuation passing ...

>> (and a pile of  duplicated code)?
>
> Which code is duplicated?

Handling gpu hangs essentially. If we just latch a work item we can
reuse all the wait and notify logic we already have. And in the past
we've had divergent changes in this area.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list