[Intel-gfx] [PATCH] drm/sysfs: expose the "force" connector attribute

[Daniel Vetter]

On Mon, May 19, 2014 at 04:44:15PM +0200, David Herrmann wrote:
> Hi
> 
> On Mon, May 19, 2014 at 4:41 PM, Thomas Wood <thomas.wood at intel.com> wrote:
> > On 19 May 2014 15:13, David Herrmann <dh.herrmann at gmail.com> wrote:
> >> Hi
> >>
> >> On Mon, May 19, 2014 at 3:37 PM, Thomas Wood <thomas.wood at intel.com> wrote:
> >>> Signed-off-by: Thomas Wood <thomas.wood at intel.com>
> >>
> >> The commit-msg lacks any discussion why this change is done. What is
> >> the reason to do that? Isn't the kernel-command-line enough? Why is
> >> this a regular feature instead of a debugfs attribute?
> >
> >
> > It was intended as a debug/testing feature to allow tests in
> > intel-gpu-tools to enable or disable connectors:
> >
> > http://lists.freedesktop.org/archives/intel-gfx/2014-May/045556.html
> >
> >
> > I'll update the commit message for the next version of the patch.
> 
> Thanks! But please make it a debugfs feature, if possible. We
> shouldn't expose interfaces in sysfs that aren't part of the core API.
> Note that this might require you to encode the connector-name in the
> debugfs-attribute-name.

Imo having the read and write side in completely different parts doesn't
make a lot of sense. Hence I think doing this in sysfs is ok. Also users
might want to frob this for testing, and usually debugfs is a bit further
away on most systems.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch