[Intel-gfx] [v3] drm/i915: Detect if MIPI panel based on VBT and initialize only if present
Ville Syrjälä
ville.syrjala at linux.intel.com
Tue May 27 16:31:42 CEST 2014
On Tue, May 27, 2014 at 03:17:15PM +0100, Damien Lespiau wrote:
> Sorry to be such a bore but:
>
> On Tue, May 27, 2014 at 07:33:59PM +0530, Shobhit Kumar wrote:
> > --- a/drivers/gpu/drm/i915/intel_dsi.c
> > +++ b/drivers/gpu/drm/i915/intel_dsi.c
> > @@ -660,6 +660,10 @@ bool intel_dsi_init(struct drm_device *dev)
> >
> > DRM_DEBUG_KMS("\n");
> >
> > + /* There is no detection method for MIPI so rely on VBT */
> > + if (!dev_priv->vbt.has_mipi)
> > + return false;
> > +
>
> Huum, if we can intel_dsi_init() on VLV, but we don't have a MIPI panel,
> shouldn't return true here? ie. "intel_dsi_init() was successful, we
> just don't have a MIPI panel.
Why does it even have a return value? Either it added the
connector and encoder or it didn't.
--
Ville Syrjälä
Intel OTC
More information about the Intel-gfx
mailing list