[Intel-gfx] [PATCH 4/6] drm/i915/vlv: re-order power wells so DPIO common comes after TX

[Daniel Vetter]

On Fri, May 23, 2014 at 01:16:43PM -0700, Jesse Barnes wrote:
> There may be a dependency here.
> 
> Signed-off-by: Jesse Barnes <jbarnes at virtuousgeek.org>

Hm, this implicit ordering is a bit funky imo ... If this increase in
complexity in furture platforms I think we should switch to epxlicit
depencies and grab references in turn. Turtles all the way down and all.
-Daniel

> ---
>  drivers/gpu/drm/i915/intel_pm.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index e8f0c85..fb7e23e 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -6122,12 +6122,6 @@ static struct i915_power_well vlv_power_wells[] = {
>  		.ops = &vlv_display_power_well_ops,
>  	},
>  	{
> -		.name = "dpio-common",
> -		.domains = VLV_DPIO_CMN_BC_POWER_DOMAINS,
> -		.data = PUNIT_POWER_WELL_DPIO_CMN_BC,
> -		.ops = &vlv_dpio_power_well_ops,
> -	},
> -	{
>  		.name = "dpio-tx-b-01",
>  		.domains = VLV_DPIO_TX_B_LANES_01_POWER_DOMAINS |
>  			   VLV_DPIO_TX_B_LANES_23_POWER_DOMAINS |
> @@ -6163,6 +6157,12 @@ static struct i915_power_well vlv_power_wells[] = {
>  		.ops = &vlv_dpio_power_well_ops,
>  		.data = PUNIT_POWER_WELL_DPIO_TX_C_LANES_23,
>  	},
> +	{
> +		.name = "dpio-common",
> +		.domains = VLV_DPIO_CMN_BC_POWER_DOMAINS,
> +		.data = PUNIT_POWER_WELL_DPIO_CMN_BC,
> +		.ops = &vlv_dpio_power_well_ops,
> +	},
>  };
>  
>  #define set_power_wells(power_domains, __power_wells) ({		\
> -- 
> 1.8.4.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch