[Intel-gfx] [PATCH i-g-t 1/4] lib: add the ability to include a description with a test

[Thomas Wood]

On 3 November 2014 12:26, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Tue, Oct 28, 2014 at 03:10:25PM +0000, Damien Lespiau wrote:
>> On Tue, Oct 28, 2014 at 03:03:53PM +0000, Thomas Wood wrote:
>> > +extern const char* __igt_test_description __attribute__((weak));
>> > +#define IGT_TEST_DESCRIPTION(a) const char* __igt_test_description = a;
>>
>> It's usual to omit the ';' here to have the macro invokation always
>> finish with a ';' (your next patch mixes both).
>
> Since you need to go through them all anyway small style bikeshed, but I
> think the multi-line arguments to macros look funny.  What about
>
> #define IGT_TEST_DESCPIPTION const char * __igt_test_description
>
> and use them like
>
> IGT_TEST_DESCRIPTION =
> "blbl"
> "blbl";

The macro was originally going to include some extra parameters with
more details. It may still be useful to add them at some point
(perhaps a shorter summary line or some basic requirements).


>
> Imo slightly easier on the eyes ;-)
>
> Otherwise this looks like a good start. So either way pls push after
> addressing Damien's feedback.

The v2 of this series includes Damien's feedback, as well as some other fixes.


> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch