[Intel-gfx] [PATCH v3 2/5] drm/i915: Use batch pools with the command parser

[Volkin, Bradley D]

On Tue, Nov 04, 2014 at 02:30:14AM -0800, Daniel Vetter wrote:
> On Mon, Nov 03, 2014 at 11:19:42AM -0800, bradley.d.volkin at intel.com wrote:
> > +			flags |= I915_DISPATCH_SECURE;
> 
> I've forgotten one: You must have a full ppgtt check here since the
> binding for aliasing ppgtt is still broken - all PIN_GLOBAL stuff still
> ends up in the ppgtt ptes too, so yourspace can still get at your shadow
> batch.

Hmm. We have a check for USES_PPGTT in i915_needs_cmd_parser(). Should we
change that to USES_FULL_PPGTT and just not do any parser stuff without
full ppgtt? I guess I'm just wondering if there's a benefit to running the
parser in a case where we can't enable secure dispatch.

Brad

> -Daniel
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> +41 (0) 79 365 57 48 - http://blog.ffwll.ch