[Intel-gfx] [PATCH 1/2] drm/i915/vlv: don't save panel power sequencer registers on suspend

Daniel Vetter daniel at ffwll.ch
Wed Nov 12 10:40:51 CET 2014


On Wed, Nov 12, 2014 at 09:52:20AM +0200, Jani Nikula wrote:
> On Tue, 11 Nov 2014, Ville Syrjälä <ville.syrjala at linux.intel.com> wrote:
> > On Tue, Nov 11, 2014 at 04:48:03PM +0200, Jani Nikula wrote:
> >> Don't save the panel power sequencer register on vlv/chv for two simple
> >> reasons. First, these are the wrong registers to save to begin
> >> with. Second, they are not restored anyway.
> >
> > Indeed. I also like how the display save/restore functions look nothing
> > alike. Scary piece of code this, hopefully someone will kill it all at
> > some point...
> 
> Yup, one patch at a time!

Yeah that effort stalled a bit unfortunately, thanks for picking it up.
Hopefully we can clear out the remaining gunk when we remove the UMS code.
At least we should see a lot clearer what's still left.

> > But anyways, patch is good, so:
> > Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Both patches merged, thanks.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list