[Intel-gfx] [PATCH] drm/i915: Propagate invalid setcrtc cloning errors back to userspace

[Daniel Vetter]

On Mon, Nov 17, 2014 at 12:10:25PM -0800, Jesse Barnes wrote:
> On Mon, 17 Nov 2014 11:17:22 -0800
> Matt Roper <matthew.d.roper at intel.com> wrote:
> 
> > On Mon, Nov 17, 2014 at 08:06:47PM +0100, Daniel Vetter wrote:
> > > On Mon, Nov 17, 2014 at 09:59:28AM -0800, Matt Roper wrote:
> > > > When invalid cloning configurations were detected during modeset, we
> > > > never copied the error code into the return value variable, leading us
> > > > to return 0 (success) to userspace.
> > > > 
> > > > Testcase: igt/kms_setmode
> > > > Signed-off-by: Matt Roper <matthew.d.roper at intel.com>
> > > 
> > > I guess this is a regression from 
> > > 
> > > commit 50f5275698df4490046cc5b4ed2018abb642a803
> > > Author: Jesse Barnes <jbarnes at virtuousgeek.org>
> > > Date:   Fri Nov 7 13:11:00 2014 -0800
> > > 
> > >     drm/i915: use compute_config in set_config v4
> > > 
> > > Is this the one we have a bugzilla for already? Jesse?
> > > -Daniel
> > 
> > Looks like it might be this one:
> > 
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86226
> 
> Ah you found it already?  Nice.
> 
> Reviewed-by: Jesse Barnes <jbarnes at virtuousgeek.org>

Queued for -next, thanks for the patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch