[Intel-gfx] [PATCH 08/15] drm/i915: remove PSR BDW single frame update.

[R, Durgadoss]

>-----Original Message-----
>From: Intel-gfx [mailto:intel-gfx-bounces at lists.freedesktop.org] On Behalf Of Rodrigo Vivi
>Sent: Friday, November 14, 2014 10:23 PM
>To: intel-gfx at lists.freedesktop.org
>Cc: Vivi, Rodrigo
>Subject: [Intel-gfx] [PATCH 08/15] drm/i915: remove PSR BDW single frame update.
>
>Single frame update is a feature available on BDW for PSR that allows
>Source to send Sink only one frame and get it updated. Usually useful
>when page fliping. However with our frontbuffer tracking where we force

flipping

>psr exit on flips we don't need this feature.
>
>Also after it got added here many workaround was added to documentation
>to mask some bits when using single frame update. So the safest thing
>is to just stop using it.
>
>Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>

Again, I have not looked at the BDW spec. But the commit message
sounds reasonable. So,

Reviewed-by: Durgadoss R <durgadoss.r at intel.com>

Thanks,
Durga

>---
> drivers/gpu/drm/i915/intel_psr.c | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c
>index 4cfe7a4..66d24c2 100644
>--- a/drivers/gpu/drm/i915/intel_psr.c
>+++ b/drivers/gpu/drm/i915/intel_psr.c
>@@ -180,7 +180,6 @@ static void intel_psr_enable_source(struct intel_dp *intel_dp)
> 		val |= EDP_PSR_LINK_STANDBY;
> 		val |= EDP_PSR_TP2_TP3_TIME_0us;
> 		val |= EDP_PSR_TP1_TIME_0us;
>-		val |= IS_BROADWELL(dev) ? BDW_PSR_SINGLE_FRAME : 0;
> 	} else
> 		val |= EDP_PSR_LINK_DISABLE;
>
>--
>1.9.3
>
>_______________________________________________
>Intel-gfx mailing list
>Intel-gfx at lists.freedesktop.org
>http://lists.freedesktop.org/mailman/listinfo/intel-gfx