[Intel-gfx] [PATCH] sna/kgem: Gen8 blt broken when dest base offset has bit 4 set

Mika Kuoppala mika.kuoppala at linux.intel.com
Wed Nov 19 14:10:05 CET 2014


With bit 4 set in destination base address, the Gen8 blitter
fails and blits errorneously into area before destination
(dest - 16 bytes), corrupting memory.

Broken hw is suspect.

v2: Update the destination base offset pattern as revealed
    by igt/tests/gem_userptr_blits/destination-bo-align

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=79053
Cc: Chris Wilson <chris at chris-wilson.co.uk>
Tested-by: xunx.fang at intel.com
Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com>
---
 src/sna/kgem.h | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/sna/kgem.h b/src/sna/kgem.h
index 6adae3b..344dcea 100644
--- a/src/sna/kgem.h
+++ b/src/sna/kgem.h
@@ -551,6 +551,11 @@ static inline bool kgem_bo_blt_pitch_is_ok(struct kgem *kgem,
 					   struct kgem_bo *bo)
 {
 	int pitch = bo->pitch;
+
+	/* bdw is broken with blit dst align */
+	if (kgem->gen >= 0100 && pitch & (1 << 4))
+		return false;
+
 	if (kgem->gen >= 040 && bo->tiling)
 		pitch /= 4;
 	if (pitch > MAXSHORT) {
-- 
1.9.1




More information about the Intel-gfx mailing list