[Intel-gfx] [PATCH 5/5] drm/i915: Flatten engine init control flow

[Chris Wilson]

On Thu, Nov 20, 2014 at 12:33:08AM +0100, Daniel Vetter wrote:
> Now that sanity prevails and we have the clean split between software
> init and starting the engines we can drop all the "have we allocate
> this struct already?" nonsense.

Actually, I was hoping for something completely different when you sad
flattening the init...

Compare with
http://cgit.freedesktop.org/~ickle/linux-2.6/tree/drivers/gpu/drm/i915/intel_ringbuffer.c#n1983

There is a lot of duplicated code in the ringbuffer setup, and the code
movement here wants to be split differently so that the sequence is
identical to execlists. (The only difference is that we only use one
ring with legacy, rather than one ring in each context [per-engine].)
Making sure the logic is foolproof for both is esssential.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre