[Intel-gfx] [PATCH 1/5] drm/i915: s/init()/init_hw()/ in intel_engine_cs

[Daniel Vetter]

On Thu, Nov 20, 2014 at 08:03:29AM +0000, Chris Wilson wrote:
> On Thu, Nov 20, 2014 at 12:33:04AM +0100, Daniel Vetter wrote:
> > This is (mostly, some exceptions that need fixing) the hw setup
> > function which starts the ring. And not the function which allocates
> > all the resources.
> > 
> > Make this clear by giving it a better name.
> 
> ->resume() because it should be only called in the resume paths after
> init! And we should have a ->susped() as well.
> 
> (Not keen on the init_hw we have spread out.)

Well that's what the bunch is currently called - there's lots more init_hw
functions. I agree it's confusing but I'm not terribly offended really.
And fixing that up would be a much larger and more invasive patch.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch