[Intel-gfx] [PATCH] drm/i915: Check locking in i915_gem_request_unreference

Daniel Vetter daniel.vetter at ffwll.ch
Wed Nov 26 13:48:11 CET 2014


On Wed, Nov 26, 2014 at 1:46 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
>> Daniel: Should I fold the WARN_ON patch into my patch series and repost?

Nope I'll wrestle while applying.

>> Chris: Are you saying that you want an extra patch to rename
>> 'drm_i915_gem_request' to 'drm_i915_request' throughout the entire
>> driver?
>
> Not even struct drm_i915_request, just struct i915_request and friends.

Imo let's settle things first a bit, rename fests can be easily done
with cocci. But yeah dropping the drm_ and gem_ prefixes sounds like a
good idea for all the request handling. We want to reuse requests for
SVM direct submission, which is totally not going to look like gem at
all.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list