[Intel-gfx] [PATCH 3/5] drm/i915: Move intel_init_pipe_control out of engine->init_hw

[Dave Gordon]

On 19/11/14 23:33, Daniel Vetter wrote:
> With this all the ->init_hw hooks really only set up hw state needed
> to start the ring, all the software state setup and memory/buffer
> allocations happen beforehand.
> 
> v2: We need to call intel_init_pipe_control after the ring init since
> otherwise engine->dev is NULL and it falls over. Currently that's
> now after the hw ring is enabled but a) we'll be fine as long as no
> one submits a batch b) this will change soon.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>

I was going to say that it would be nice to move the init_hw() out of
intel_init_ring_buffer() and logical_ring_init() so that they actually
do what their names say, but I see that's forthcoming, so

Reviewed-by: Dave Gordon <david.s.gordon at intel.com>

.Dave.