[Intel-gfx] [PATCH 0/3] BYT DSI Dual Link Support

[Daniel Vetter]

On Thu, Nov 27, 2014 at 01:20:06PM +0530, Singh, Gaurav K wrote:
> 
> On 11/24/2014 2:31 PM, Jani Nikula wrote:
> >On Mon, 24 Nov 2014, "Singh, Gaurav K" <gaurav.k.singh at intel.com> wrote:
> >>Hi Jani,
> >>
> >>Thanks for the review comments.
> >>
> >>Regarding the first 2 patches, I was doing almost the same thing in my
> >>3rd and 4th patch. But your patches are more generic.
> >>
> >>Regarding the 3rd patch, I have a comment:
> >>
> >>Since in case of dual link panels, few panels may require sequence to be
> >>sent only on Port A or Port C or both. In that case,
> >>for_each_dsi_port(port, intel_dsi->ports) will cause it to be sent to
> >>both ports.
> >>To resolve this, in the earlier patches, intel_dsi->port was used which
> >>gets calculated to either 0 or 1 in mipi_exec_send_packet(). This value
> >>of 0 or 1 is dependent on sequence block#53.
> >>
> >>  From now on as we will be using the _PORT3() macro for using proper
> >>MIPI regs, then for this scenario, we may need to have some
> >>workaround/hardcode type of code again. May I know your suggestion on this?
> >Perhaps patch 3/3 was a bad place for the for_each_dsi_port example - it
> >should have been put into intel_dsi.c. Maybe you'll need to add the port
> >as parameter to the functions in intel_dsi_cmd.c, and let the caller
> >decide which port should be used? I want to avoid any platform/panel
> >specific special casing in intel_dsi.c and intel_dsi_cmd.c.
> >
> >I think the general case for for_each_dsi_port is in intel_dsi.c anyway.
> >
> >BR,
> >Jani.
> Jani,
> 
> I have taken care of this in the next version of dual link patches. PATCH
> 3/3 need not be merged as it has already been taken care as part of dual
> link implementation. Once your first two patches gets merged in
> drm-intel-nightly branch, I can push the next version of dual link patches
> for review.
> 
> With regards,

Both patches merged, thanks.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch