[Intel-gfx] [PATCH 4/5] drm/i915: Only init engines once

[Chris Wilson]

On Fri, Nov 28, 2014 at 06:56:24PM +0100, Daniel Vetter wrote:
> On Fri, Nov 28, 2014 at 12:02:40PM +0000, Dave Gordon wrote:
> > On 19/11/14 23:33, Daniel Vetter wrote:
> > > We can do this.
> > > 
> > > And now there's finally the clean split between software setup and
> > > hardware setup I kinda wanted since multi-ring support was merged
> > > aeons ago. It only took almost 5 years.
> > > 
> > > Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> > > ---
> > >  drivers/gpu/drm/i915/i915_gem.c         | 13 ++++++++++---
> > >  drivers/gpu/drm/i915/intel_lrc.c        |  6 ------
> > >  drivers/gpu/drm/i915/intel_ringbuffer.c |  4 ----
> > >  3 files changed, 10 insertions(+), 13 deletions(-)
> > 
> > Yep, that's what I was hoping for :)
> > 
> > Reviewed-by: Dave Gordon <david.s.gordon at intel.com>
> 
> Thanks for the review, I've merged the first 3 patches from here.
> 
> > (Mind you, I like Chris's suggestions too, especially converting all the
> > historical /ring/ to the more accurate /engine/).
> 
> Yup, we're not going to run out of polish patches for a long time in GEM.
> I actually chatted about this with Jon Ewins and he brought up the
> possibility that someone from his team would dig into this full-time.
> Otherwise it'll take ages to get the accumulated cruft of the past few
> years out and document the tribal knowledge.

I spent 8 hours doing so one day only to get completely ignored.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre