[Intel-gfx] [PATCH] drm/i915: Revert "drm/i915: Reject the pin ioctl on gen6+"

Bloomfield, Jon jon.bloomfield at intel.com
Thu Oct 2 12:40:39 CEST 2014


On Fri, Sep 19, 2014 Daniel Vetter wrote:
> I still consider pinning stuff behind the kernels back too evil. So if people
> want that I'd like to see the use-case and why we can't do this differently.
> 
> And I've never approved of the pin ioctl but really loudly complained about
> each occasion I've spotted, so I think the internal users just have to keep the
> pieces for a bit longer.
> -Daniel

Daniel. All that's being asked for is a re-instatement of the old mechanism until
a better solution can be designed and implemented. 

It may well be evil, but the mechanism was there, and was the only known
way to handle the OA buffer, so why wouldn't someone use it ? You've broken 
userspace before you provided any alternative solution.

Please, let's revert this while a more elegant solution is designed, implemented,
reviewed, re-implemented, reviewed again, and maybe one day merged.

Remember that it will take a while to filter down to people even after you merge
any new solution to nightly, or even drm-next. If we have to wait for the new
design, it's not likely to reach us until next year.

Can't we just agree that we're evil, but turn a blind eye while we're coaxed slowly
back towards the light ?

Jon



More information about the Intel-gfx mailing list