[Intel-gfx] [RFC 01/21] Bug: missing i915_seqno_passed() call?

John.C.Harrison at Intel.com John.C.Harrison at Intel.com
Mon Oct 6 16:15:05 CEST 2014


From: John Harrison <John.C.Harrison at Intel.com>

---
 drivers/gpu/drm/i915/i915_gem.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 2a5351d..8c68219 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu/drm/i915/i915_gem.c
@@ -2886,7 +2886,7 @@ i915_gem_object_sync(struct drm_i915_gem_object *obj,
 	seqno = obj->last_read_seqno;
 	/* Optimization: Avoid semaphore sync when we are sure we already
 	 * waited for an object with higher seqno */
-	if (seqno <= from->semaphore.sync_seqno[idx])
+	if (seqno <= from->semaphore.sync_seqno[idx]) /* <--- broken?! needs to use i915_seqno_passed()??? */
 		return 0;
 
 	ret = i915_gem_check_olr(obj->ring, seqno);
-- 
1.7.9.5




More information about the Intel-gfx mailing list