[Intel-gfx] [PATCH 6/6] tools/null_state_gen: Add GEN9 golden context batch buffer creation

Damien Lespiau damien.lespiau at intel.com
Fri Oct 10 14:03:32 CEST 2014


On Thu, Oct 09, 2014 at 07:54:39PM +0300, Mika Kuoppala wrote:
> From: Armin Reese <armin.c.reese at intel.com>
> 
> Modifications to 'null_state_gen' so it can generate GEN9
> golden context batch buffer source for SKL.
> 
> v2: - rebased on top of gen8 changes (Mika)
>     - fixed state base address command size (Mika)
>     - base address size macro as pages (Mika)
> 
> v3: - rebased on top of current master (Mika)
>     - removed obsolete #includes (Mika)
>     - added copyright (Mika)
>     - render and component packing added (Mika)
> 
> Cc: Damien Lespiau <damien.lespiau at intel.com>
> Cc: Armin Reese <armin.c.reese at intel.com>
> Cc: Volkin, Bradley D <bradley.d.volkin at intel.com>
> Signed-off-by: Armin Reese <armin.c.reese at intel.com> (v1)
> Signed-off-by: Mika Kuoppala <mika.kuoppala at intel.com>

Hi,

This looks really good, I think we should just push it. There was a
suggestion to make the null state generator output the copyright notice
along with the generated file as well, but that can be done whenever.

-- 
Damien



More information about the Intel-gfx mailing list