[Intel-gfx] [RFC 02/21] drm/i915: Remove redundant parameter to i915_gem_object_wait_rendering__tail()

[Daniel Vetter]

On Sun, Oct 19, 2014 at 2:25 PM, Daniel Vetter <daniel at ffwll.ch> wrote:
> On Mon, Oct 06, 2014 at 03:15:06PM +0100, John.C.Harrison at Intel.com wrote:
>> From: John Harrison <John.C.Harrison at Intel.com>
>
> Empty commit messages are a bit too thin. E.g. in this case this was an
> oversight from
>
> commit c8725f3dc0911d4354315a65150aecd8b7d0d74a
> Author: Chris Wilson <chris at chris-wilson.co.uk>
> Date:   Mon Mar 17 12:21:55 2014 +0000
>
>     drm/i915: Do not call retire_requests from wait_for_rendering
>
> which means your patch here really should have Cc'ed patch author and
> revierer (i.e. Chris & Brad) of the offending patch, too.

To make things clear: Cc'ing people isn't to assign blame for every
single mistake they do (we're all racking up impressive amounts of
them anyway), but to give them a learning opportunity and the chance
to improve. It is pretty much impossible to follow intel-gfx and read
everything that's on here even for me, so if you don't cc people for
even the most mundane and small things they'll miss the mail.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch