[Intel-gfx] [RFC 00/21] Replace seqno values with request structures

Daniel Vetter daniel at ffwll.ch
Sun Oct 19 19:15:53 CEST 2014


On Mon, Oct 6, 2014 at 5:17 PM, Chris Wilson <chris at chris-wilson.co.uk> wrote:
> On Mon, Oct 06, 2014 at 03:15:04PM +0100, John.C.Harrison at Intel.com wrote:
>> From: John Harrison <John.C.Harrison at Intel.com>
>>
>> Work in progress for replacing seqno usage with requst structures.
>
> You fail to end up with my earlier code. Nak.

Well I've tried to split up your patch into small independent changes
and failed at that. And given how many changes there are in there I
simply can't merge your patch as-is. I know that it does seem to fix
some random hangs, but with massive behaviour changes like the
read-read stuff in there this could very well just be a random fluke.

But if there's anything amiss in John's work for the plain
s/seqno/request/ change, or anything else that we absolutely need to
have then I very much want your opinion on this. But a flat outright
nak without further content isn't useful to move forward.

Thanks, Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch



More information about the Intel-gfx mailing list