[Intel-gfx] [PATCH] drm/i915/bdw: Clean up execlist queue items in retire_work

[Daniel, Thomas]

> -----Original Message-----
> From: Chris Wilson [mailto:chris at chris-wilson.co.uk]
> Sent: Monday, October 20, 2014 2:11 PM
> To: Daniel, Thomas
> Cc: intel-gfx at lists.freedesktop.org; shuang.he at linux.intel.com
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/bdw: Clean up execlist queue
> items in retire_work
> 
> On Mon, Oct 20, 2014 at 02:05:55PM +0100, Thomas Daniel wrote:
> > No longer create a work item to clean each execlist queue item.
> > Instead, move retired execlist requests to a queue and clean up the
> > items during retire_requests.
> >
> > v2: Fix legacy ring path broken during overzealous cleanup
> 
> At some point I presume you noticed that you broke the idle detection...
This patch doesn't change the idle detection.  Did you want the idle flag to
now take into account the state of the execlists requests as well?

> Please do read http://patchwork.freedesktop.org/patch/33175/ and
> reconsider.
Are you saying that my patch is not required because that patch reworks the
code?

Cheers,
Thomas.

> -Chris
> 
> --
> Chris Wilson, Intel Open Source Technology Centre