[Intel-gfx] [PATCH 1/4] drm/i915: Remove unnecessary test on the gen in intel_do_mmio_flip()

Chris Wilson chris at chris-wilson.co.uk
Sat Oct 25 11:04:45 CEST 2014


On Sat, Oct 25, 2014 at 10:01:12AM +0100, Chris Wilson wrote:
> On Sat, Oct 25, 2014 at 12:11:11AM +0100, Damien Lespiau wrote:
> > use_mmio_flip() makes sure we only enable MMIO flips on gen5+. So we
> > don't need to take into account older devices.
> 
> Honestly, I prefer to keep the gen test here (around touching gen
> specifc portions of common registers). It stops it later biting
> back if we relax mmioflip to run on older gen.

On the other hand, DSPSURF is gen4+. Ok, might as put a comment in there
that it is gen4+ specific and remove the check.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre



More information about the Intel-gfx mailing list